Skip to content

Fix fixture source warning on AddOverrideAttributeToOverriddenMethodsRector (missing TestCase suffix)#7869

Merged
samsonasik merged 1 commit intomainfrom
fix-warning
Jan 30, 2026
Merged

Fix fixture source warning on AddOverrideAttributeToOverriddenMethodsRector (missing TestCase suffix)#7869
samsonasik merged 1 commit intomainfrom
fix-warning

Conversation

@samsonasik
Copy link
Member

Before

➜  rector-src git:(main) vendor/bin/phpunit rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector                                                      
PHPUnit 12.5.8 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.16
Configuration: /Users/samsonasik/www/rector-src/phpunit.xml

.......................                                           23 / 23 (100%)

Time: 00:02.700, Memory: 178.50 MB

There was 1 PHPUnit test runner warning:

1) Class Rector\Tests\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector\Source\SomeAbstractTest declared in /Users/samsonasik/www/rector-src/rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/Source/SomeAbstractTest.php is abstract

OK, but there were issues!
Tests: 23, Assertions: 26, PHPUnit Warnings: 1.

After

➜  rector-src git:(main) ✗ vendor/bin/phpunit rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector
PHPUnit 12.5.8 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.16
Configuration: /Users/samsonasik/www/rector-src/phpunit.xml

.......................                                           23 / 23 (100%)

Time: 00:02.648, Memory: 178.50 MB

OK (23 tests, 26 assertions)

@samsonasik samsonasik enabled auto-merge (squash) January 30, 2026 23:38
@samsonasik samsonasik merged commit 5b90a0c into main Jan 30, 2026
57 checks passed
@samsonasik samsonasik deleted the fix-warning branch January 30, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant